Share common fabric-scoped table-like storage from SceneTableImpl #38073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to a templatized class, chip::common::FabricTableImpl, to allow re-use in other clusters (specifically, TlsClientManagementServer)
gmarcosb
force-pushed
the
camera-webrtc-server
branch
from
4ba315a to
9934b77
Compare
|
PR #38073: Size comparison from 09dd3ac to c18aec4 Full report (3 builds for nrfconnect)
|
gmarcosb
force-pushed
the
camera-webrtc-server
branch
from
5436ca2 to
ff085b5
Compare
bzbarsky-apple
requested changes
Mar 24, 2025
| }; | ||
| template <class EFStype> | ||
| class SceneTable | ||
| : public virtual app::common::FabricTable<scene_table_elements::SceneStorageId, scene_table_elements::SceneData<EFStype>> |
There was a problem hiding this comment.
Why do we need virtual inheritance here?
| virtual CHIP_ERROR GetSceneTableEntry(FabricIndex fabric_index, SceneStorageId scene_id, SceneTableEntry & entry) = 0; | ||
| virtual CHIP_ERROR RemoveSceneTableEntry(FabricIndex fabric_index, SceneStorageId scene_id) = 0; | ||
| virtual CHIP_ERROR RemoveSceneTableEntryAtPosition(EndpointId endpoint, FabricIndex fabric_index, SceneIndex scene_idx) = 0; | ||
| inline CHIP_ERROR SetSceneTableEntry(FabricIndex fabric_index, const SceneTableEntry & entry) |
There was a problem hiding this comment.
So this is changing from an abstract interface (with SceneTableImpl as a possible, but not only, implementation) to a concrete implementation, right? Was this discussed with @lpbeliveau-silabs ?
| kSceneCount, | ||
| kStorageIDArray, | ||
| kGroupID, | ||
| kGroupID = 4, |
There was a problem hiding this comment.
This seems to be assuming something about something. Where is this 4 coming from?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move functionality to a templatized class,
chip::common::FabricTableImpl, to allow re-use in other clusters (specifically,TlsClientManagementServer)Testing
Tested in CI